Skip to content

Sidnioulz/danger js on forks proof of innocuity#34221

Closed
Sidnioulz wants to merge 3 commits into
nextfrom
sidnioulz/danger-js-on-forks-proof-of-innocuity
Closed

Sidnioulz/danger js on forks proof of innocuity#34221
Sidnioulz wants to merge 3 commits into
nextfrom
sidnioulz/danger-js-on-forks-proof-of-innocuity

Conversation

@Sidnioulz

@Sidnioulz Sidnioulz commented Mar 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This PR is targeting next. It should run the source branch and it should run the user-modified danger script.

Summary by CodeRabbit

  • Chores
    • Updated PR workflow configuration and event triggers.
    • Removed automated PR validation checks previously enforced on submissions.

@Sidnioulz Sidnioulz marked this pull request as ready for review March 19, 2026 12:54
@Sidnioulz Sidnioulz added ci: do not merge ci:normal Run our default set of CI jobs (choose this for most PRs). labels Mar 19, 2026
@Sidnioulz Sidnioulz force-pushed the sidnioulz/danger-js-on-forks-proof-of-innocuity branch from f4fb9c6 to 0b547d3 Compare March 19, 2026 12:55
@coderabbitai

coderabbitai Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8e4fc13-0ed5-4223-a571-92ffe21cfa63

📥 Commits

Reviewing files that changed from the base of the PR and between 1240072 and 0b547d3.

📒 Files selected for processing (2)
  • .github/workflows/danger-js.yml
  • scripts/dangerfile.js
📝 Walkthrough

Walkthrough

This PR modifies the Danger CI configuration by changing the workflow trigger event from pull_request to pull_request_target and expanding branch filters, while replacing all validation logic in the Danger script with a single console.log statement, effectively disabling PR validation checks.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/danger-js.yml		 Updated trigger event from pull_request to pull_request_target and added sidnioulz/danger-js-on-forks to the branch allowlist alongside existing main and next branches.
Danger Script Logic
scripts/dangerfile.js		 Removed all PR validation logic including Danger imports, configuration loading from code/package.json, label validation (forbidden/required CI and PR labels), PR title format checks, and manual testing section enforcement. Replaced with a single console.log statement.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Important

Merge conflicts detected (Beta)

  • Resolve merge conflict in branch sidnioulz/danger-js-on-forks-proof-of-innocuity
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci: do not merge ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sidnioulz